-
Notifications
You must be signed in to change notification settings - Fork 123
Add dev support for Windows ARM builds #9987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
E2E Tests 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I was able to get a development version going on Windows on Arm (couple bumps, which were sorted).
Tested:
- Detects both x64 and Arm R installs ✅
- Confirmed expected processes (Positron, Air, Ark, Kallichore) are running as Arm processes ✅
- Confirmed spawning x64 R spawns x64 Ark ✅
- Confirmed Copilot functions as expected ✅
Of note: Python works as expected using x64 binaries, but Arm binaries throws an error on launching a session:
Traceback (most recent call last):
File "c:\Users\Sam\Documents\positron\extensions\positron-python\python_files\posit\positron_language_server.py", line 10, in <module>
from positron.positron_ipkernel import (
...<3 lines>...
)
File "c:\Users\Sam\Documents\positron\extensions\positron-python\python_files\posit\positron\positron_ipkernel.py", line 18, in <module>
import psutil
File "c:\Users\Sam\Documents\positron\extensions\positron-python\python_files\lib\ipykernel\arm64\cp3\psutil\__init__.py", line 100, in <module>
from . import _pswindows as _psplatform
File "c:\Users\Sam\Documents\positron\extensions\positron-python\python_files\lib\ipykernel\arm64\cp3\psutil\_pswindows.py", line 30, in <module>
from ._psutil_windows import ABOVE_NORMAL_PRIORITY_CLASS
ImportError: DLL load failed while importing _psutil_windows: %1 is not a valid Win32 application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5e060f5

This change adds developer support for producing dev and release builds on Windows ARM. It does not actually add Windows ARM release builds, as those require infrastructure we do not yet have.
Rough outline of changes:
R-aarch64EMFILEissues on Windows ARM builderProgress towards #5254.